ref: Make SentryProfilingConditionals private #6868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
noahsmartin
force-pushed
the
sentryProfilingConditionalsPrivate
branch
5 times, most recently
from
11bbba3 to
f1a5ef0
Compare
noahsmartin
force-pushed
the
sentryProfilingConditionalsPrivate
branch
from
f1a5ef0 to
1b84e43
Compare
philprime
approved these changes
Nov 24, 2025
Member
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM, thank you for the new comments in the code
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| 07f6759 | 1232.98 ms | 1267.59 ms | 34.61 ms |
| 42a95d5 | 1206.00 ms | 1224.26 ms | 18.26 ms |
| 7629df7 | 1224.80 ms | 1250.29 ms | 25.49 ms |
| 474ae14 | 1217.54 ms | 1241.44 ms | 23.90 ms |
| b358363 | 1228.33 ms | 1262.34 ms | 34.01 ms |
| e446901 | 1233.32 ms | 1252.32 ms | 19.00 ms |
| a3dfd57 | 1230.78 ms | 1244.91 ms | 14.14 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 07f6759 | 23.75 KiB | 997.26 KiB | 973.52 KiB |
| 42a95d5 | 23.75 KiB | 906.08 KiB | 882.33 KiB |
| 7629df7 | 23.75 KiB | 959.45 KiB | 935.70 KiB |
| 474ae14 | 24.14 KiB | 1.01 MiB | 1014.11 KiB |
| b358363 | 23.75 KiB | 987.92 KiB | 964.18 KiB |
| e446901 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| a3dfd57 | 23.75 KiB | 913.63 KiB | 889.87 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't need to be public, no other public headers use it now that SentryOptions is in Swift
#skip-changelog
Closes #6869